MAYA-128503 - Improve roundtripping of GeomSubsets #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two sources of GeomSubsets in Maya: - Shaded faces - Explicitly create component tags In USD land GeomSubsets can be modified in ways that have no Maya equivalent: - We can change the family name - We can assign a material So when importing/exporting USD data, we need to add just enough info that all Maya and USD sepcificities are accounted for and correctly handled. The unit test will be quite informative.
|
I'll wait for the code update and answers about the small details, otherwise LGTM. |
| def testGeomSubsetRoundtripCollectionBased(self): | ||
| """Test that GeomSubsets numbers stay under control when rountripping | ||
| with collection based material assignemnt""" | ||
| self.CommonGeomSubsetRoundtrip(True) |
There was a problem hiding this comment.
The way the material checks are done with ComputeBoundMaterial work with both assignment methods. The contents of the USDA files will be slightly different since one will use collections based assignment.
| @@ -449,6 +449,12 @@ bool UsdMayaTranslatorMaterial::AssignMaterial( | |||
| // identifier is the UUID. | |||
| subsetRoundtrippingInfo[UsdMayaGeomSubsetTokens->MaterialUuidKey] | |||
| = JsValue(depNodeFn.uuid().asString().asChar()); | |||
| } else { | |||
| TF_RUNTIME_ERROR( | |||
There was a problem hiding this comment.
Would it be necessary to also have an error for the iterator check above? IDK what are the semantics for the find to fail.
There was a problem hiding this comment.
Yes, I will revisit the error handling today as this seem a bit fragile.
pierrebai-adsk
previously approved these changes
Jun 5, 2023
…ove_subset_roundtripping
pierrebai-adsk
previously approved these changes
Jun 5, 2023
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk , ready for merge as the 3 preflight failures for Maya 2024 are known. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two sources of GeomSubsets in Maya:
In USD land GeomSubsets can be modified in ways that have no Maya equivalent:
So when importing/exporting USD data, we need to add just enough info that all Maya and USD sepcificities are accounted for and correctly handled.
The unit test will be quite informative.