EMSUSD-189 fix undo of the stage creation command #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Jul 10, 2023
pierrebai-adsk
commented
- Do not keep reference to temporarily created DAG modifiers.
- Capture the undo item by using a undo item list and undo recorder.
- Don't hide potential unrelated exceptions.
- Add a unit test for the command.
pierrebai-adsk
added
bug
- Do not keep reference to temporarily created DAG modifiers. - Capture the undo item by using a undo item list and undo recorder. - Don't hide potential unrelated exceptions. - Add a unit test for the command.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-189/undo-create-stage
branch
from
8448fcf
to
97532b9
Compare
|
@pierrebai-adsk One question I have is during the command if any part of it fails, is everything that was created and/or modified up to that point undone? |
|
Yes, that is what the undo at line 70 (for exceptions) and 74 (for explicit return failure) do. |
frohnej-adsk
requested changes
Jul 11, 2023
Co-authored-by: frohnej-adsk <116098583+frohnej-adsk@users.noreply.github.com>
pierrebai-adsk
commented
Jul 11, 2023
frohnej-adsk
approved these changes
Jul 11, 2023
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
approved these changes
Jul 12, 2023
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.