-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOOKDEVX-1688 - Fix extra Arnold refresh when moving nodes #3241
Merged
seando-adsk
merged 2 commits into
dev
from
gamaj/LOOKDEVX-1688/ignore_shading_custom_data
Jul 24, 2023
Merged
LOOKDEVX-1688 - Fix extra Arnold refresh when moving nodes #3241
seando-adsk
merged 2 commits into
dev
from
gamaj/LOOKDEVX-1688/ignore_shading_custom_data
Jul 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feldstj
previously approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor suggestion.
@@ -238,8 +245,14 @@ UsdMayaStageNoticeListener::ClassifyObjectsChanged(UsdNotice::ObjectsChanged con | |||
for (PathRange::const_iterator it = pathsToUpdate.begin(); it != pathsToUpdate.end(); ++it) { | |||
if (it->IsAbsoluteRootOrPrimPath()) { | |||
const TfTokenVector changedFields = it.GetChangedFields(); | |||
if (!changedFields.empty()) { | |||
for (auto&& changedField : changedFields) { | |||
if (changedField == SdfFieldKeys->CustomData && it->IsPrimPath()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these two if conditions be combined?
feldstj
approved these changes
Jul 21, 2023
JGamache-autodesk
added
the
ready-for-merge
Development process is finished, PR is ready for merge
label
Jul 21, 2023
@seando-adsk ready for merge. |
seando-adsk
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.