Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOOKDEVX-1688 - Fix extra Arnold refresh when moving nodes #3241

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

JGamache-autodesk
Copy link
Collaborator

No description provided.

feldstj
feldstj previously approved these changes Jul 20, 2023
Copy link
Collaborator

@feldstj feldstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor suggestion.

@@ -238,8 +245,14 @@ UsdMayaStageNoticeListener::ClassifyObjectsChanged(UsdNotice::ObjectsChanged con
for (PathRange::const_iterator it = pathsToUpdate.begin(); it != pathsToUpdate.end(); ++it) {
if (it->IsAbsoluteRootOrPrimPath()) {
const TfTokenVector changedFields = it.GetChangedFields();
if (!changedFields.empty()) {
for (auto&& changedField : changedFields) {
if (changedField == SdfFieldKeys->CustomData && it->IsPrimPath()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these two if conditions be combined?

@JGamache-autodesk JGamache-autodesk added the ready-for-merge Development process is finished, PR is ready for merge label Jul 21, 2023
@JGamache-autodesk
Copy link
Collaborator Author

@seando-adsk ready for merge.

@seando-adsk seando-adsk merged commit 0df5c90 into dev Jul 24, 2023
@seando-adsk seando-adsk deleted the gamaj/LOOKDEVX-1688/ignore_shading_custom_data branch July 24, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arnold Related to Arnold ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants