EMSUSD-76 - [GitHub #2991] Editing Purpose on a prim doesn't update in the viewport until prim is deselected #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlasovi
commented
Jul 27, 2023
Comment on lines
+1893
to
+1910
| if (anyPurposeChanged || rprimRenderTagChanged || !_taskRenderTagsValid) { | ||
| TfTokenVector renderTags | ||
| = { HdRenderTagTokens->geometry }; // always draw geometry render tag purpose. | ||
| if (_proxyShapeData->DrawRenderPurpose() || renderPurposeChanged) { | ||
| if (_proxyShapeData->DrawRenderPurpose() || renderPurposeChanged || rprimRenderTagChanged) { | ||
| renderTags.push_back(HdRenderTagTokens->render); | ||
| } | ||
| if (_proxyShapeData->DrawProxyPurpose() || proxyPurposeChanged) { | ||
| if (_proxyShapeData->DrawProxyPurpose() || proxyPurposeChanged || rprimRenderTagChanged) { | ||
| renderTags.push_back(HdRenderTagTokens->proxy); | ||
| } | ||
| if (_proxyShapeData->DrawGuidePurpose() || guidePurposeChanged) { | ||
| if (_proxyShapeData->DrawGuidePurpose() || guidePurposeChanged || rprimRenderTagChanged) { | ||
| renderTags.push_back(HdRenderTagTokens->guide); | ||
| } | ||
| _taskController->SetRenderTags(renderTags); | ||
| // if the changedRenderTags is not empty then we could have some tags | ||
| // in the _taskController just so that we get one sync to hide the render | ||
| // items. In that case we need to leave _taskRenderTagsValid false, so that | ||
| // we get a chance to remove that tag next frame. | ||
| _taskRenderTagsValid = !anyPurposeChanged; | ||
| _taskRenderTagsValid = !(anyPurposeChanged || rprimRenderTagChanged); |
There was a problem hiding this comment.
Those changes here are a pure refactoring. No behavioural change intended.
pierrebai-adsk
approved these changes
Jul 31, 2023
vlasovi
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accomodating render tags update for USD 23.02