EMSUSD-278 - Embed import options in subheadings #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
samuelliu-adsk
commented
Jul 27, 2023
•
samuelliu-adsk
commented
- Embed import options in subheading
- Change the style from progressive disclosure to Maya style (grey out children options when parent unselected)
samuelliu-adsk
changed the title
|
Preview of the change: |
seando-adsk
reviewed
Jul 28, 2023
| @@ -229,24 +229,26 @@ global proc int mayaUsdTranslatorImport (string $parent, | |||
| // menuItem -label "Object space"; | |||
| // menuItem -label "World space"; | |||
| // optionMenuGrp -e -sl 1 mayaUsdTranslator_CoordSystemOptionMenu; | |||
| frameLayout -label `getMayaUsdString("kImportMaterialsLbl")` materialsFrameLayout; | |||
| separator -style "none"; | |||
| checkBoxGrp -label "" -label1 `getMayaUsdString("kImportMaterialsLbl")` -cw 1 $cw1 -value1 1 -ann `getMayaUsdString("kImportMaterialsAnn")` -cc ("mayaUsdTranslatorImport_MaterialsCB") mayaUsdTranslator_MaterialsCheckBox; | |||
There was a problem hiding this comment.
I'm not sure what the default is, but I think you should pass the number of checkboxes with -ncb 1 and I don't think you need -label "" as that flag is optional. Same with all the ones below.
There was a problem hiding this comment.
Hi @seando-adsk , -label "" is actually needed to achieve the alignment. Without -label the option will be aligned to the left as shown below:
For -ncb I'm not sure it's necessary.. We didn't use that option before so I think that's more for the case that we have multiple checkboxes?
There was a problem hiding this comment.
Okay for the empty label - I didn't realize that.
I checked the code for the checkBoxGrp command and it does indeed default to 1.
seando-adsk
approved these changes
Jul 28, 2023
samuelliu-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.