Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMSUSD-291 Refactored MayaUSD help content ids #3255

Merged
merged 4 commits into from
Aug 10, 2023
Merged

EMSUSD-291 Refactored MayaUSD help content ids #3255

merged 4 commits into from
Aug 10, 2023

Conversation

AramAzhari-adsk
Copy link
Collaborator

MayaUSD help content ids now live in its own help table (helpTableMayaUSD) in MayaUSD repo.
Please refer to mayaUsd_help.py for usage.

@AramAzhari-adsk
EMSUSD-291 Refactored MayaUSD help content ids
7eaf707 
Moved MayaUSD Help Table into MayaUSD repo.
Please refer to mayaUsd_help.py for usage.
@AramAzhari-adsk AramAzhari-adsk added the adsk Related to Autodesk plugin label Jul 31, 2023
seando-adsk
seando-adsk requested changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the helpTable and python helper should be moved from adsk to mayaUsd.

plugin/adsk/scripts/mayaUsd_help.py Outdated Show resolved Hide resolved
plugin/adsk/CMakeLists.txt Outdated Show resolved Hide resolved
plugin/adsk/scripts/mayaUsd_help.py Outdated Show resolved Hide resolved
@AramAzhari-adsk
Moved the help function to mayaUsdUtils.py.
82012c9 
Also moved the helpTable to maya-Usd/resources folder.
@AramAzhari-adsk
Updated the helptable path to use an env variable
44801a5 
The newly defined env variable is MAYAUSD_LIB_LOCATION which points to the 'lib' path.
@AramAzhari-adsk AramAzhari-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Aug 10, 2023
@seando-adsk seando-adsk merged commit 55d44c9 into dev Aug 10, 2023
@seando-adsk seando-adsk deleted the azharia/EMSUSD-291/Move-MayaUSD-HelpTable-ContentIds-Into-MayaUSD branch August 10, 2023 18:41
@AramAzhari-adsk AramAzhari-adsk mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seando-adsk seando-adsk seando-adsk approved these changes

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
adsk Related to Autodesk plugin ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AramAzhari-adsk @seando-adsk @ecp-maya-devops-adsk