MAYA-103736 Clear frameSamples set #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when the flag is used.
kxl-adsk
reviewed
Mar 4, 2020
HamedSabri-adsk
added
adsk
fowlertADSK
commented
Mar 9, 2020
| @@ -93,6 +93,7 @@ UsdMayaExportTranslator::writer(const MFileObject &file, | |||
| theOption[1].split(',', filteredTypes); | |||
| } | |||
| else if (argName == "frameSample") { | |||
| frameSamples.clear(); | |||
There was a problem hiding this comment.
The default value of 0.0 for frameSample will always be listed in the options. If the flag is explicitly set then we'll parse it a second time and add in all of the associated values, so we need to clear the set before parsing it that second time.
kxl-adsk
approved these changes
Mar 9, 2020
ppt-adsk
pushed a commit
that referenced
this pull request
Feb 28, 2023
* MAYA-127016 : Support viewport XRay shading mode * MAYA-127016 : Add a comment for the hardcoded value of opacity and use a struct for the constructor of MayaHydraMaterialNetworkConverter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear frameSamples set so that we don't add in the default value when the flag is used.