-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine how to read UsdLux prims with an envvar #3385
Determine how to read UsdLux prims with an envvar #3385
Conversation
This eliminates the need for the build var and allows this to be set at runtime
@dj-mcg I saw your preflight failed on a few tests related to lights. |
Oops! Having a peek |
I see the issue, but I need to ask the Usd team a few questions about how to properly approach translators of types with codeless schemas, so it may be a day or two before I update this PR |
The problematic types are defined in renderman. We're currently rethinking how we go about registering these readers as it would be great to get rid of a build flag requirement if possible. I'm thinking we might want to define these readers in the renderman-for-maya plugin but I'm still unsure whether there is precedent for introducing dependencies on mayaUsd in that plugin. Maybe these make the most sense living inside an internal pixar plugin - let me know if you have thoughts about registering readers for externally defined types! |
Sorry for the delay, @seando-adsk - I removed the offending light types and moved them to an internal plugin |
This eliminates the need for the build var and allows this to be set at runtime