Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine how to read UsdLux prims with an envvar #3385

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

dj-mcg
Copy link
Collaborator

@dj-mcg dj-mcg commented Oct 13, 2023

This eliminates the need for the build var and allows this to be set at runtime

This eliminates the need for the build var and allows this to be set at
runtime
@seando-adsk
Copy link
Collaborator

@dj-mcg I saw your preflight failed on a few tests related to lights.

@dj-mcg
Copy link
Collaborator Author

dj-mcg commented Oct 16, 2023

Oops! Having a peek

@dj-mcg
Copy link
Collaborator Author

dj-mcg commented Oct 16, 2023

I see the issue, but I need to ask the Usd team a few questions about how to properly approach translators of types with codeless schemas, so it may be a day or two before I update this PR

@dj-mcg
Copy link
Collaborator Author

dj-mcg commented Oct 25, 2023

@dj-mcg I saw your preflight failed on a few tests related to lights.

The problematic types are defined in renderman. We're currently rethinking how we go about registering these readers as it would be great to get rid of a build flag requirement if possible. I'm thinking we might want to define these readers in the renderman-for-maya plugin but I'm still unsure whether there is precedent for introducing dependencies on mayaUsd in that plugin. Maybe these make the most sense living inside an internal pixar plugin - let me know if you have thoughts about registering readers for externally defined types!

@dj-mcg
Copy link
Collaborator Author

dj-mcg commented Nov 10, 2023

@dj-mcg I saw your preflight failed on a few tests related to lights.

Sorry for the delay, @seando-adsk - I removed the offending light types and moved them to an internal plugin

@seando-adsk seando-adsk added the import-export Related to Import and/or Export label Nov 13, 2023
@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 17, 2023
@seando-adsk seando-adsk merged commit 565798d into Autodesk:dev Nov 17, 2023
10 checks passed
@dj-mcg dj-mcg deleted the pr/Use_EnvVar_For_RfmLight_Import branch November 17, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants