EMSUSD-632 prevent root metadata changes when not targeting root #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Oct 18, 2023
•
pierrebai-adsk
commented
- Add a applyRootLayerMetadataRestriction helper function to enforce not modifying the root layer metadata when not targeting the root layer.
- The only restriction applied is about the default prim.
- Call it from within the applyCommandRestriction helper function.
- Call it from within the default prim commands.
- Add unit tests for the rename, parent and group default prim restrictions.
- Add tests for the default prim commands.
pierrebai-adsk
added
enhancement
- Add a applyRootLayerMetadataRestriction helper function to enforce not modifying the root layer metadata when not targeting the root layer. - The only restriction applied is about the default prim. - Call it from within the applyCommandRestriction helper function. - Call it from within the default prim commands. - Add unit tests for the rename, parent and group default prim restrictions. - Add tests for the default prim commands.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-632/prevent-renaming-root-prim
branch
from
ca96687 to
0d9de70
Compare
- Wrap commands for Python. - Use commands instead of USD calls in AE. - Allow clearing the default prim with only a stage in addition to with a prim.
|
The Attribute Editor now uses the command and can be undone. |
|
Once again, the only PF failure is one interactive test in a single PF where a USD file was left behind in the temp folder from e previous PF, that failure can be ignored. |
seando-adsk
requested changes
Oct 20, 2023
seando-adsk
approved these changes
Oct 23, 2023
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.