Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-550 - Disable Material section when Mesh type is excluded from export #3421

Merged

Conversation

samuelliu-adsk
Copy link
Collaborator

Disable the material section when user excludes Meshes from export. Currently the material is attached to the mesh so when the mesh is not exported, the material can not be exported either.

seando-adsk
seando-adsk previously approved these changes Oct 31, 2023
@seando-adsk seando-adsk added the import-export Related to Import and/or Export label Oct 31, 2023
@samuelliu-adsk
Copy link
Collaborator Author

Hi @seando-adsk , just realize I have some debug code forgot to remove. Added another commit

Comment on lines -491 to -494
} else if($optionBreakDown[0] == "exportCameras"){
mayaUsdTranslatorExport_SetOptionMenuByBool($optionBreakDown[1], $enable, "exportInstancesPopup");
} else if($optionBreakDown[0] == "exportLights") {
mayaUsdTranslatorExport_SetOptionMenuByBool($optionBreakDown[1], $enable, "exportInstancesPopup");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these lines removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those lines are some debug code I used before and forgot to remove. They are totally useless now...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would they be useless. Someone can call this function adding those strings to the input options to control the starting value of these two export options.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no those flags are not longer available. Now we use excludeExportTypes flag, so it will be excludeExportTypes=[Cameras, Lights] like this. These two flags are abandoned. It's my fault I forgot to delete them here...

@samuelliu-adsk samuelliu-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 2, 2023
@seando-adsk seando-adsk merged commit c3bb8a8 into dev Nov 2, 2023
11 checks passed
@seando-adsk seando-adsk deleted the samuelliu-adsk/EMSUSD-550/disable_material_mesh_off branch November 2, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants