Commits on Nov 2, 2023

1. EMSUSD-749 fix how stages are updated when saved …

   The interaction between how the stage were initially open or created and how
   they were updated did not match. This caused the code that attempted to update
   the stage cache when saving anonymous layers to fail to achieve its goal. This
   led to the proxy shape next compute to fail to find the original session layer.
   This caused the information about edited-as-Maya prim to be lost. This resulted
   in the stage being in a weird state where a Maya reference prim was edited but
   the stage had forgotten about it.
   
   Fix the code so that the way the stage os open in the proxy shape and in the
   function that update the stage cache match.
   
   - Changed how the proxy shape open the USD stage by always initially not loading payloads.
   - Also, do not pass an explicit resolver as it would affect which stage could be found in the cache.
   - Document in the helper function that updates stage after saving anonymous layer to open the stages the same way.
   
   We also needed to fix the layer manager UI update after save.
   
   The previous code worked by happenstance of the order of indirect operations.
   In particular, it only worked if the proxy shape was recomputed at just the
   right time. Recomputing the proxy shape emitted a notice that refreshed the
   layer manager. For complex reasons, when there is an edited Maya reference, the
   order changes, which prevented the layer manager UI from updating with the
   latest data.
   
   To avoid this reliance on the exact timing of when the proxy shape might get
   recomputed, an explicit call to refresh the underlying model of the layer
   manager is done when saving. Unfortunately, due to the complicated design of
   the layer manager, the underlying tree model and where the data is kept,
   multiple classes had to be modified to provide a path from the save code the
   the data model.
   
   - Add functions on the MayaSessionState to refresh the current displayed stage layers.
   - (The MayaSessionState is where the layer manager UI keeps its list of loaded USD stages... it really ough to be called LoadedStages instead... MayaSessionState is a combination of three meaningless words.)
   - Add a updateLayerModel() abstract function to the AbstractLayerEditorWindow interface.
   - Implement updateLayerModel() in MayaLayerEditorWindow by calling the refreshStageEntry() on the MayaSessionStage.
   - Add a updateLayerManagers(0 helper function to the LayerDatabase used by the LayerManager (that is, the data holder, not the UI), to refresh all layer manager UI.
   - Call it at the end of LayerDatabase::saveUsd(), which is where layers get saved.

   

   pierrebai-adsk committed Nov 2, 2023
   16 Configuration menu

   • View commit details
   • Copy full SHA for 9a7886c
   • Browse repository at this point

   Copy the full SHA

   9a7886c View commit details

   Browse the repository at this point in the history

2. EMSUSD-749 fix a test that assumed loading a stage produced no load r… …

   …ules.
   
   Also improve two comments.

   

   pierrebai-adsk committed Nov 2, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for e9959c5
   • Browse repository at this point

   Copy the full SHA

   e9959c5 View commit details

   Browse the repository at this point in the history