Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to UsdImagingDelegate::PopulateSelection param change #345

Merged

Conversation

mattyjams
Copy link
Contributor

With USD_IMAGING_API_VERSION 11, UsdImagingDelegate::PopulateSelection() expects to be given a USD path instead of a Hydra "index path". This helps to avoid some confusion about
the types of paths being passed around.

@kxl-adsk kxl-adsk added the build Related to building maya-usd repository label Mar 9, 2020
@kxl-adsk
Copy link

@mattyjams We missed our internal update of USD by a few days. I don't believe there is any rush in this PR, so we can keep it open for a week or two?

… index path

With USD_IMAGING_API_VERSION 11, PopulateSelection() expects to be given a USD
path instead of a Hydra "index path". This helps to avoid some confusion about
the types of paths being passed around.

This change corresponds to core USD commit
760904c80d8c38d83a4fca079d2414b8288e22cf.

(Internal change: 2046886)
This identifies core USD commit 893c8e4 (post 20.02 release) as the most recent
supported version of USD.
@mattyjams mattyjams force-pushed the pr/usdImaging_PopulateSelection_usdPath_param branch from ef9af3b to fb155cb Compare March 11, 2020 22:48
@mattyjams
Copy link
Contributor Author

@kxl-adsk This change shouldn't require the latest version of USD, as the "new" code is gated on USD_IMAGING_API_VERSION, but if you need to put it on hold for a while, then that's ok. We need this internally, so we're merging it into what we build and deploy.

I just rebased it following the merge of #346.

@kxl-adsk
Copy link

How often USD_IMAGING_API_VERSION is updated? At every breaking change?

@mattyjams
Copy link
Contributor Author

I'm not quite sure exactly how rigorous we're being about that, but at least for this particular change, the API version was bumped for this specific API change. The core USD commit was PixarAnimationStudios/OpenUSD@760904c.

@kxl-adsk
Copy link

Roger that. Then we should be able to get it in sooner. Thank you for clarification @mattyjams

@kxl-adsk kxl-adsk merged commit 38185d2 into Autodesk:dev Mar 13, 2020
@mattyjams mattyjams deleted the pr/usdImaging_PopulateSelection_usdPath_param branch March 13, 2020 19:18
ppt-adsk pushed a commit that referenced this pull request Feb 28, 2023
…ace instead of free functions (#345)

* MAYA-127453: combine util.cpp/h and utils.cpp/h; add mayahydra namespace instead of free functions

* MAYA-127453: remove using ns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants