EMSUSD-603 - Errors when trying to cache a rig with merge transforms ON and namespaces OFF #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelliu-adsk
commented
Nov 20, 2023
| @@ -471,8 +471,6 @@ def testEditAndMergeRigMayaRef(self): | |||
| value = xformOp.Get() | |||
| self.assertIn("xformOp:translate", value) | |||
| self.assertIn("xformOp:rotateXYZ", value) | |||
| self.assertIn("xformOp:translate:channel1", value) | |||
| self.assertIn("xformOp:rotateXYZ:channel1", value) | |||
There was a problem hiding this comment.
Removed these two lines because those are not valid any more, but I don't know if there's any other ways to test it...
samuelliu-adsk
commented
Nov 20, 2023
| @@ -195,7 +195,8 @@ SdfPath UsdMayaWriteJobContext::ConvertDagToUsdPath(const MDagPath& dagPath) con | |||
| // write to the parent (transform) path instead. | |||
There was a problem hiding this comment.
As the comment stated, we should only write to parent if the current node is a shape node
| @@ -690,6 +690,8 @@ void AddMayaExtents( | |||
| MAYAUSD_CORE_PUBLIC | |||
| SdrShaderNodePtrVec GetSurfaceShaderNodeDefs(); | |||
|
|
|||
| bool isShape(const MDagPath& dagPath); | |||
There was a problem hiding this comment.
I think we shoudl export it by adding MAYAUSD_CORE_PUBLIC, like the other functions.
pierrebai-adsk
requested changes
Nov 21, 2023
pierrebai-adsk
approved these changes
Nov 21, 2023
samuelliu-adsk
added
import-export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
channel1part of the unity test because that attribute is created because of the bug above. I compared the cache to usd result to a normal export and the files matches (there's nochannel1in normal export usd files)