LOOKDEVX-0000 - Fix legacy CM nodes affected by MaterialX 1.38.8 #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a change in MaterialX 1.38.8 that heavily modified the CM implementations provided. Fixing this required copying the relevant code from 1.38.7 to MayaUSD so the nodes can continue working. I have backed-up all the implementation code affected in the 1.38.7 folder, with a version specific install so 1.38.7 continues working.
| @@ -0,0 +1,11 @@ | |||
| #include "libraries/stdlib/genglsl/lib/mx_transform_color.glsl" | |||
There was a problem hiding this comment.
All these new files in the 1.37.7 folder are copies of files modified for 1.38.8 before changes.
| @@ -1,8 +1,8 @@ | |||
| #include "libraries/stdlib/genglsl/lib/mx_transform_color.glsl" | |||
| #include "libraries/adsk/maya/genglsl/lib/usd_transform_color.glsl" | |||
There was a problem hiding this comment.
Changes requires copying the old mx_transform_color.glsl to MayaUSD since that file no longer exists in 1.38.8.
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk Ready for merge. Thanks! |
seando-adsk
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change in MaterialX 1.38.8 that heavily modified the CM implementations provided.
Fixing this required copying the relevant code from 1.38.7 to MayaUSD so the nodes can continue working.
I have backed-up all the implementation code affected in the 1.38.7 folder, with a version specific install so 1.38.7 continues working.