EMSUSD-788 support relative cache to USD in anon layers #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the layer does not have a file path when caching to USD, then remember the absolute path and the fact it must be made relative when the layer gets saved. Saving the layer automatically updates the path. - Add a cache-to-USD test for relative cache in an anonymous layer. - Exposed to Python the function to update the postponed relatve paths in a layer.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-788/relative-cache-usd
branch
from
9fe609a
to
55b6218
Compare
| /*! \brief Turns the file paths marked through the call 'markPathAsPostponedRelative' to relative. | ||
| */ | ||
| MAYAUSD_CORE_PUBLIC | ||
| void updatePostponedRelativePaths(const PXR_NS::SdfLayerHandle& layer); |
There was a problem hiding this comment.
I'm not sure about this but would it be better if we give the layerFileName a default value so we can just keep one method?
There was a problem hiding this comment.
The default value that would get passed is taken from the layer handle, and we have to account for the possibility that the handle is null. It is simpler to have an overload.
samuelliu-adsk
approved these changes
Dec 7, 2023
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the layer does not have a file path when caching to USD, then remember the absolute path and the fact it must be made relative when the layer gets saved. Saving the layer automatically updates the path.