EMSUSD-852 allow saving locked layers #3504
Conversation
Relevant change is the removal of the call to isReadOnly().
| @@ -267,13 +267,21 @@ bool LayerTreeItem::isIncoming() const { return _isIncomingLayer; } | |||
|
|
|||
| bool LayerTreeItem::needsSaving() const | |||
| { | |||
| if (_layer) { | |||
| if (!isSessionLayer() && !isReadOnly() | |||
There was a problem hiding this comment.
The removal of the call to isReadOnly() is the only real change, all the other is just avoiding the complex nesting of conditionals and multi-line conditions, allowing to document what each condition does.
There was a problem hiding this comment.
So if I understand it correctly, the needsSaving() function will return true even if permissionToSave is false, and that flag will be checked later when actually writing the layer
There was a problem hiding this comment.
NO, isReadOnly checks permission to edit, not save. We currently do not have check for permission to save, but then again, USD itself will refuse to save, so we don't need to check it to prevent it. When we do the future work to have a UI for permission to save, we might had new verifications.
pierrebai-adsk
requested review from
luceric-adsk and
samuelliu-adsk
and removed request for
luceric-adsk and
samuelliu-adsk
|
I found that I can fix EMSUSD-850 at the same time, so I will do so. The fix is related to this one. |
The double-click handle was only checking if the layer was anonymous, instead of all teh case where it needed to be saved or was prevented to be saved.
|
The only PF failures were unrelated material VP2 test screenshot differing. Running those test locally succeeded. |
pierrebai-adsk
added
the
ready-for-merge
Relevant change is the removal of the call to isReadOnly(). I refactored the function to avoid nested if and complex conditional that are hard to understand. Also commented on what each condition aims to do.