LOOKDEVX-1625 - Use proper API to set color space in USD #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGamache-autodesk
requested review from
seando-adsk and
stefanminning-autodesk
feldstj
previously approved these changes
Dec 14, 2023
| @@ -406,6 +406,9 @@ Ufe::Value UsdAttributeHolder::getMetadata(const std::string& key) const | |||
| } | |||
| #endif | |||
| return Ufe::Value(niceName); | |||
| } else if (key == SdfFieldKeys->ColorSpace) { | |||
| auto csValue = _usdAttr.GetColorSpace(); | |||
| if (isValid()) { | ||
| if (key == SdfFieldKeys->ColorSpace) { | ||
| if (!value.empty() && value.isType<std::string>()) { | ||
| AttributeEditRouterContext ctx(_usdAttr.GetPrim(), _usdAttr.GetName()); |
seando-adsk
previously approved these changes
Dec 14, 2023
JGamache-autodesk
dismissed stale reviews from seando-adsk and feldstj
via
36b9ee4
feldstj
approved these changes
Dec 14, 2023
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk Ready for merge. |
seando-adsk
deleted the
gamaj/LOOKDEVX-1625/metadata_support_for_color_space
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.