Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOOKDEVX-2324 - Export MaterialX path for extra nodes #3516

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

JGamache-autodesk
Copy link
Collaborator

Allow 3rd party renderers to see MayaUSD MaterialX library and render the nodes.

Allow 3rd party renderers to see MayaUSD MaterialX library and render
the nodes.
@JGamache-autodesk
Copy link
Collaborator Author

This allows Arnold to "see" the NodeGraph implementations of nodes like MayaND_fileTexture_*, MayaND_place2dTexture_vector2, LdkND_ColorCorrect_color4 and render them correctly.

Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this variable need when running the unit tests? If so it needs to be added to test.cmake as we don't use the .mod file when running tests.

@JGamache-autodesk
Copy link
Collaborator Author

No, only used by third party renderers (Arnold, VRay, PRMan maybe). So is not used in unit tests.

Test failure on Linux is one of the usual: testVP2RenderDelegateDisplayLayers

@JGamache-autodesk JGamache-autodesk added ready-for-merge Development process is finished, PR is ready for merge and removed ready-for-merge Development process is finished, PR is ready for merge labels Dec 14, 2023
@JGamache-autodesk
Copy link
Collaborator Author

@seando-adsk Ready for merge (preflight failure was a random one).

@seando-adsk seando-adsk merged commit 57d0a88 into dev Dec 15, 2023
11 of 13 checks passed
@seando-adsk seando-adsk deleted the gamaj/LOOKDEVX-2324/add_mayausd_mx_path_to_modfile branch December 15, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arnold Related to Arnold ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants