EMSUSD-671 Remove the load payloads proxy shape attribute #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
added
adsk
pierrebai-adsk
removed
the
do-not-merge-yet
Instead, we will always use the existing payload rules dynamic attribute. - Remove the "loadPayloads" attribute from the proxy shape. - Add Python binding to new functions to set and retrieve if all payloads are loaded or not. - Split-up existing load-rules helper functions to give more fined-grained access to the saved load rules in order to support the Python API. - Use the new Python helper functions when creating or loading a stage. - Adjust one unit test.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-671/remove-payload-attr
branch
from
c5e51db
to
90f788c
Compare
pierrebai-adsk
commented
Dec 21, 2023
pierrebai-adsk
commented
Dec 21, 2023
pierrebai-adsk
commented
Dec 21, 2023
pierrebai-adsk
commented
Dec 21, 2023
pierrebai-adsk
commented
Dec 21, 2023
pierrebai-adsk
commented
Dec 21, 2023
AramAzhari-adsk
previously approved these changes
Dec 21, 2023
pierrebai-adsk
added
ready-for-merge
This ensure backward compatibility with old scene files and avoids having warnings when loading such old scenes. Only make the attribute not show up in the UI to force users to use the context menu to change the loaded status of payloads.
|
@AramAzhari-adsk @seando-adsk for a refresher: the thing I changed after approval was put back the attribute to avoid warnings when loading old scenes. |
AramAzhari-adsk
approved these changes
Jan 9, 2024
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, we will always use the existing payload rules dynamic attribute.