LOOKDEVX-2403 - Allow creating custom types at NodeGraph boundaries #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating NodeGraph/Material inputs and outputs, allow passing the native type as a string instead of "Generic" when creating a port that can only be wrapped in UFE as an UfeAttributeGeneric. This allows LookdevX to display the expected port type when promoting ports on inner nodes.
JGamache-autodesk
requested review from
feldstj,
seando-adsk and
pierrebai-adsk
feldstj
previously approved these changes
Jan 18, 2024
pierrebai-adsk
previously approved these changes
Jan 18, 2024
JGamache-autodesk
dismissed stale reviews from pierrebai-adsk and feldstj
via
4cf8fd3
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk Ready for merge. Build fix commit was only a missing UFE_V3 check and does not change the logic. |
pierrebai-adsk
approved these changes
Jan 19, 2024
feldstj
approved these changes
Jan 19, 2024
seando-adsk
deleted the
gamaj/LOOKDEVX-2403/allow_creating_custom_types_at_nodegraph_boundaries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating NodeGraph/Material inputs and outputs, allow passing the native type as a string instead of "Generic" when creating a port that can only be wrapped in UFE as an UfeAttributeGeneric.
This allows LookdevX to display the expected port type when promoting ports on inner nodes.