EMSUSD-972 add unit test for circular relationships #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
added
the
do-not-merge-yet
pierrebai-adsk
added
adsk
The test revealed a flaw in the code that follows relations and connections. Fixed the code to not go into an infinite loop when there are circular relationships or connections. - Fix infinite recursion when relations or connections form a circle. - Added many test for connections, similar to those for relations. - Refactored the test code to allow testing relations or connections. - Added tests for circular targets. - Added test for mix or relationships and connections.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-972/more-copy-prim-unit-test
branch
from
458f315 to
f81f80b
Compare
|
Seems I had to rebase to avoid github think I had a huge PR |
AramAzhari-adsk
approved these changes
Jan 25, 2024
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test revealed a flaw in the code that follows relations and connections. Fixed the code to not go into an infinite loop when there are circular relationships or connections.