Maya is no longer using a Preview Release number #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove code (currently not used) that detected this.
seando-adsk
commented
Feb 8, 2024
Comment on lines
-264
to
-271
| if(MAYA_INCLUDE_DIRS AND EXISTS "${MAYA_INCLUDE_DIR}/maya/MDefines.h") | ||
| file(STRINGS ${MAYA_INCLUDE_DIR}/maya/MDefines.h MAYA_PREVIEW_RELEASE_VERSION REGEX "#define MAYA_PREVIEW_RELEASE_VERSION.*$") | ||
| if(MAYA_PREVIEW_RELEASE_VERSION) | ||
| string(REGEX MATCHALL "[0-9]+" MAYA_PREVIEW_RELEASE_VERSION ${MAYA_PREVIEW_RELEASE_VERSION}) | ||
| else() | ||
| set(MAYA_PREVIEW_RELEASE_VERSION 0) | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
This file will be removed from future versions of Maya, so remove the check for it. We currently aren't using any preview release checks.
seando-adsk
commented
Feb 8, 2024
| @@ -250,43 +247,6 @@ def createSingleSphereMayaScene(directory=None): | |||
| cmds.file(save=True, force=True, type='mayaAscii') | |||
| return tempMayaFile | |||
|
|
|||
| def previewReleaseVersion(): | |||
There was a problem hiding this comment.
Completely removed this helper - its currently not used. We have other methods for detecting how to check for things in tests (ufe support fix level, etc).
ppt-adsk
approved these changes
Feb 8, 2024
seando-adsk
added
build
|
Prefight failure was a test (GTest:AL_USDTransactionTests) timeout error on one particular run. Unrelated to my changes. |
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code (currently not used) that detected this.