EMSUSD-873 - Adds write permission checks to layer system-locking #3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AramAzhari-adsk
added
enhancement
pierrebai-adsk
previously approved these changes
Feb 22, 2024
…s-Write-Permission-Check-To-Layer-System-Locking # Conflicts: # lib/usd/ui/layerEditor/abstractCommandHook.h # lib/usd/ui/layerEditor/mayaCommandHook.h
AramAzhari-adsk
added
the
ready-for-merge
seando-adsk
reviewed
Feb 23, 2024
Comment on lines
+113
to
+121
| def GetFullStageNameFromProxyShapeAttr(attr): | ||
| # Helper method which returns the full stage name | ||
| # First get the stage name from the input attribute. | ||
| stageName = attr.split('.')[0] | ||
| # Convert that into a long Maya path so we can get the USD stage. | ||
| res = cmds.ls(stageName, l=True) | ||
| fullStageName = res[0] | ||
|
|
||
| return(fullStageName) |
There was a problem hiding this comment.
Why was this function needed? Couldn't you just have called the one above and ignore the stage?
fullStageName,_ = GetStageFromProxyShapeAttr(filePathAttr)
There was a problem hiding this comment.
Fair point. I have an upcoming PR and I am taking note to address this.
There was a problem hiding this comment.
Okay thanks. I'll merge this one then.
seando-adsk
removed
enhancement
seando-adsk
deleted the
azharia/EMSUSD-873/Adds-Write-Permission-Check-To-Layer-System-Locking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the layer operations will refresh the system-lock based on the write permissions of those layers. The operations are as follows:
Note that: