EMSUSD-877 Update the look of the Layer Editor. #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Feb 29, 2024
pierrebai-adsk
commented
- Make the action buttons only be drawn when active or when the mouse is over the layer item in the layer editor.
- Change all the layer item action icons with the new provided images.
- Make the text, icons all be draw muted when the item is disabled.
- Use different images for on/off and hover.
- Don't draw a background rectangle under the action icons.
- Make each layer item row be 24 pixels high.
- Adjust action icon centering for narrower rows.
- Use same code to paint edit target and action icons.
- Show the mouse cursor with the context menu marker in the layer editor.
- Move save count badge to the left of the save button and adjust its rendering.
- Remove the 1-pixel offset when an layer item is selected.
- Pass multiple data needed to draw an item in struct to simplify calls.
- Adjust the offset of the disable striped background so that it aligns between rows.
- Adjust the striped background positioning taking into consideration the position of the item and its indentation.
- Adjust background color of the layer editor.
- Add hover highlight of the layer row.
- Update striped background.
- Fixed the problems that some tooltips were not showing.
- Simplified the tooltip handling code..
- Elide the name of layers with ellipsis when too long to fit.
pierrebai-adsk
added
adsk
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-877/lock-mute-on-hover
branch
from
115b9ad
to
ca4ed47
Compare
- Make the action buttons only be drawn when active or when the mouse is over the layer item in the layer editor. - Change all the layer item action icons with the new provided images. - Make the text, icons all be draw muted when the item is disabled. - Use different images for on/off and hover. - Don't draw a background rectangle under the action icons. - Make each layer item row be 24 pixels high. - Adjust action icon centering for narrower rows. - Use same code to paint edit target and action icons. - Show the mouse cursor with the context menu marker in the layer editor. - Move save count badge to the left of the save button and adjust its rendering. - Remove the 1-pixel offset when an layer item is selected. - Pass multiple data needed to draw an item in struct to simplify calls. - Adjust the offset of the disable striped background so that it aligns between rows. - Adjust the striped background positioning taking into consideration the position of the item and its indentation. - Adjust background color of the layer editor. - Add hover highlight of the layer row. - Update striped background. - Fixed the problems that some tooltips were not showing. - Simplified the tooltip handling code.. - Elide the name of layers with ellipsis when too long to fit.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-877/lock-mute-on-hover
branch
from
ca4ed47
to
1b29020
Compare
AramAzhari-adsk
requested changes
Feb 29, 2024
AramAzhari-adsk
previously approved these changes
Mar 1, 2024
AramAzhari-adsk
previously approved these changes
Mar 1, 2024
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
reviewed
Mar 7, 2024
seando-adsk
approved these changes
Mar 8, 2024
AramAzhari-adsk
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.