EMSUSD-877 UI tweaks #3649
Merged
EMSUSD-877 UI tweaks #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Mar 6, 2024
pierrebai-adsk
commented
- Move add-layer button left to the border of the panel.
- Don't show context-menu mouse cursor over action buttons.
- Make hover highlight even over muted rows.
- Make hover highlight less dark.
- Rename some paint context flag to be clearer.
- Move "USD Stage" label to the left border.
- Don't draw text under icons with hovering.
- Make text lighter when selected.
- Simplify and centralize the action icon rectangle calculations.
- Improve arrow appearance: smaller, more square, in 6x6 square.
- Adjustment of spacing.
- Remove unnecessary error log when a layer cannot be found. The UI already shows a warning icon.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-877/layer-editor-tweaks
branch
from
0cc5260
to
116649c
Compare
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-877/layer-editor-tweaks
branch
from
116649c
to
7f1a631
Compare
- Move add-layer button left to the border of the panel. - Don't show context-menu mouse cursor over action buttons. - Make hover highlight even over muted rows. - Make hover highlight less dark. - Rename some paint context flag to be clearer. - Move "USD Stage" label to the left border. - Don't draw text under icons with hovering. - Make text lighter when selected. - Simplify and centralize the action icon rectangle calculations. - Improve arrow appearance: smaller, more square, in 6x6 square. - Adjustment of spacing. - Remove unnecessary error log when a layer cannot be found. The UI already shows a warning icon.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-877/layer-editor-tweaks
branch
from
7f1a631
to
1690bbb
Compare
pierrebai-adsk
commented
Mar 8, 2024
| @@ -140,37 +140,15 @@ void LayerTreeItem::populateChildren(RecursionDetector* recursionDetector) | |||
| for (auto const path : subPaths) { | |||
| std::string actualPath = SdfComputeAssetPathRelativeToLayer(_layer, path); | |||
| auto subLayer = SdfLayer::FindOrOpen(actualPath); | |||
| if (subLayer) { | |||
There was a problem hiding this comment.
The difference in the if/else was merely to print error message in stdout, which are not useful and we already show error icon in the UI. Simplified the code.
pierrebai-adsk
commented
Mar 8, 2024
| @@ -23,34 +23,63 @@ | |||
|
|
|||
| namespace { | |||
|
|
|||
| using ItemPaintContext = UsdLayerEditor::LayerTreeItemDelegate::ItemPaintContext; | |||
|
|
|||
| bool isInaccessible(const ItemPaintContext& ctx) | |||
There was a problem hiding this comment.
These function are used to control the opacity in various scenarios.
AramAzhari-adsk
approved these changes
Mar 8, 2024
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.