EMSUSD-1120 - Stage loading problems using MEL proc #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oblems * Make sure to init the optionvars used by the MEL command.
seando-adsk
commented
Mar 19, 2024
| // This proc is used by the unit tests (which run in standalone mode). | ||
| // In that case we need to make sure the optionVars are initialized as | ||
| // they are queried in doCreateStage(). | ||
| setOptionVars(false); |
There was a problem hiding this comment.
So what happens is on line 141 it would do:
string $ppath = optionVar -q stageFromFile_primPath;
If we are running in standalone (say from a unit test) the options vars would not have been init, and in Maya when you query an option var that doesn't exist it returns 0. The MEL code above converts that to a string and you get "0". That would then we set as the primPath on the stage. In Dan's new code this is not a valid primPath so the compute would bail early. With this fix the option vars are init and it will set "" as the primpath which converts to the root prim "/" and the compute works.
seando-adsk
commented
Mar 19, 2024
Comment on lines
+80
to
+90
| # Verify that the we have a good stage. | ||
| stage = mayaUsd.ufe.getStage(shapeNode) | ||
| self.assertTrue(stage) | ||
|
|
||
| # This stage has five layers. | ||
| layerStack = stage.GetLayerStack() | ||
| self.assertEqual(5, len(layerStack)) | ||
|
|
||
| # Finally, verify that we can get at least one of the ball prims. | ||
| ballPrim = stage.GetPrimAtPath('/Room_set/Props/Ball_1') | ||
| self.assertTrue(ballPrim.IsValid()) |
There was a problem hiding this comment.
Added some test cases to ensure the stage was correctly loaded.
seando-adsk
added
unit test
JGamache-autodesk
approved these changes
Mar 19, 2024
pierrebai-adsk
approved these changes
Mar 19, 2024
seando-adsk
added
the
ready-for-merge
seando-adsk
deleted the
donnels/EMSUSD-1120/stage_loading_problems_using_script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMSUSD-1120 - Stage loading problems using MEL proc