EMSUSD-1073 - Update for USD v24.03 #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
approved these changes
Mar 28, 2024
seando-adsk
added
the
ready-for-merge
seando-adsk
deleted the
donnels/EMSUSD-1073/usd_v24_03_do_not_use_TkToken_ref_in_struct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating to USD v24.03 the test
testMergeToUsd.pywould segfault and crash. I found its because of aconst TkToken&being stored in a struct which is then passed around. Not sure why with 24.03 this changed, but my suspicion was that token was being released elsewhere and this the ref in the struct not valid. There is no reason to store a ref in the struct. TfTokens are lightweight objects which are ref counted.