-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMSUSD-1161 - Fix the crash when attempting to save a USD file from USD Layer Editor #3697
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit strange that it returns true if the input parent item is null. How is that a safe path to add?
The reason I return |
While a corner case, there is no correct answer to the question "is is safe to add something to nothing". One could argue both ways. If it solves a crash, then I think there is no harm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only improvement I could think of is documenting the behaviour with null parent layer in the header file.
03b9aed
No description provided.