EMSUSD-895 - Payload command undo to restore payload rules #3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboisj
reviewed
Apr 12, 2024
| // Macros to handle the redo/undo actions on stage load/unload rules | ||
| // The load rules are saved before applying new rules and are | ||
| // applied back when the commands are undo | ||
| #define STAGE_PAYLOAD_ACTION(action) \ |
There was a problem hiding this comment.
Could use a function instead of a macro - with a lambda you can do the same thing. Personnally I find macros annoying to maintain and work with.
deboisj
reviewed
Apr 12, 2024
| const PXR_NS::UsdStageWeakPtr _stage; | ||
| const PXR_NS::SdfPath _primPath; | ||
| PXR_NS::UsdLoadPolicy _policy; | ||
| PXR_NS::UsdStageLoadRules _undoRules; |
There was a problem hiding this comment.
You probably want to update / add to https://git.autodesk.com/maya3d/maya-usd/blob/dev/test/lib/ufe/testPayloadCommands.py
seando-adsk
requested review from
pierrebai-adsk
and removed request for
seando-adsk
pierrebai-adsk
previously approved these changes
Apr 15, 2024
AntonK-Adsk
previously approved these changes
Apr 15, 2024
brossee-adsk
dismissed stale reviews from AntonK-Adsk and pierrebai-adsk
via
1ed41ab
brossee-adsk
added
the
ready-for-merge
seando-adsk
removed
the
ready-for-merge
|
@brossee-adsk I didn't see a preflight build. I think it might be because you assigned the PR to me which remove the check. So I unassigned your PR and then just assigned it to you. I see the preflight started. I removed the |
brossee-adsk
added
the
ready-for-merge
brossee-adsk
deleted the
brossee/EMSUSD-895/payload-undo-to-previous-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payload undo doesn't go back to previous descendants states. The fix keeps the state of the payload rules applied on the stage before executing the command to load/unload a payload. The kept state is reapplied on the stage when the undo command is requested.