EMSUSD-204 Material binding strength in AE #3736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Apr 23, 2024
pierrebai-adsk
commented
- Move the custom control class to its own file.
- Add an option menu to control the material binding strength in the attribute editor (AE).
- Change the binding strength when the user select a new value in the option menu.
- Hide the menu when the material in inherited and there is no direct material.
- Disable the menu when there is a stronger inherited material and a direct material.
- Show a tooltip that explain why it is disabled.
- Update children when material strength is changed.
- Don't change selection when going to the prim from which the material in inherited.
- Don't use italics.
- Move the custom control class to its own file. - Add an option menu to control the material binding strength in the attribute editor (AE). - Change the binding strength when the user select a new value in the option menu. - Hide the menu when the material in inherited and there is no direct material. - Disable the menu when there is a stronger inherited material and a direct material. - Show a tooltip that explain why it is disabled. - Update children when material strength is changed. - Don't change selection when going to the prim from which the material in inherited. - Don't use italics.
|
Note: the custom control class does not derive from AttributeCustomControl because it does not handle UFE attributes but "generated" data derived from the material assignment. It does not need any of the function provided by that base class. |
pierrebai-adsk
commented
Apr 24, 2024
| @@ -127,119 +127,6 @@ def onReplace(self, *args): | |||
| # Nothing needed here since we don't create any UI. | |||
| pass | |||
|
|
|||
| class MaterialCustomControl(object): | |||
There was a problem hiding this comment.
Moved to its own file
pierrebai-adsk
commented
Apr 24, 2024
| self.strengthMenu = self._createDropDownField( | ||
| 'strength', 'kLabelMaterialStrength', | ||
| ['kLabelWeakerMaterial', 'kLabelStrongerMaterial']) | ||
|
|
There was a problem hiding this comment.
The class was moved from the other file, the only changes are about this strength option menu, most of the code is unchanged.
AramAzhari-adsk
approved these changes
Apr 24, 2024
pierrebai-adsk
added
the
ready-for-merge
JGamache-autodesk
approved these changes
Apr 24, 2024
| self.item.path().segments[0], | ||
| ufe.PathSegment(fromPath, mayaUsd.ufe.getUsdRunTimeId(), '/')]) | ||
| ufePathStr = ufe.PathString.string(ufePath) | ||
| melCommand = 'updateAE "%s"' % ufePathStr |
There was a problem hiding this comment.
Another important change is using updateAE here instead of cmds.select. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.