Update googletest & gulrak (filesystem) #3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
seando-adsk
commented
May 31, 2024
seando-adsk
commented
- Set C++ version when building googletest and use shallow clone (no history is needed).
- Update gulrak version from 1.5.6 to 1.5.14.
- Remove unneeded filesystem include.
* Set C++ version when building googletest and use shallow clone (no history is needed). * Update gulrak version from 1.5.6 to 1.5.14. * Remove unneeded filesystem include.
seando-adsk
commented
May 31, 2024
| @@ -14,6 +14,7 @@ ExternalProject_Add(googletest | |||
| GIT_REPOSITORY https://github.com/google/googletest.git | |||
| GIT_TAG release-1.10.0 | |||
| GIT_CONFIG advice.detachedHead=false | |||
| GIT_SHALLOW TRUE | |||
There was a problem hiding this comment.
This will skip the history which makes the download much smaller.
| USES_TERMINAL_DOWNLOAD TRUE | ||
| GIT_CONFIG advice.detachedHead=false | ||
| gulrak | ||
| URL https://github.com/gulrak/filesystem/archive/refs/tags/v1.5.14.zip |
There was a problem hiding this comment.
The previous version was 1.5.6 (which is what that git commit pointed to) which seems like a big jump to 1.5.14, but its not that really. There weren't all the dot releases in between. https://github.com/gulrak/filesystem/releases
I also changed it so that it just downloads the release zip file instead of cloning the github repo.
| @@ -59,8 +59,6 @@ | |||
| #include <maya/MStatus.h> | |||
| #include <maya/MTime.h> | |||
|
|
|||
| #include <ghc/filesystem.hpp> | |||
There was a problem hiding this comment.
All these files aren't using filesystem, so removed the header.
AramAzhari-adsk
approved these changes
May 31, 2024
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.