EMSUSD-1196 material scope as default prim #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the material scope name to the default-prim drop-down when meshes are off and materials are on. Bug fixes and improvements: - Prune empty group at the start of the finish step of export to avoid using a prim that will be deleted as a root prim. - Don't add the default prim name as a parent of the material scope when the material scope *is* the default prim. - Add a Python helper to retrieve the default material scope name. - Remove unused default prim data member from UsdMayaPrimWriterArgs. - Refactor the parsing of encoded arguments to have the same behavior for import and export. - We now allow for empty argument values. Change how no-default-prim is expressed - At the command level, passing "None" as the default prim flag now means no default prim. - OTOH, not passing the default prim flag or an empty string means to use the first root prim as the default prim. - When exporting, if the default prim is "None", then no default prim metadata is authored. - Make sure to also handle "None" for the name of the material scope. Add unit tests.
pierrebai-adsk
commented
Jun 3, 2024
| @@ -32,7 +32,6 @@ Each base command class is documented in the following sections. | |||
| | `-apiSchema` | `-api` | string (multi) | none | Imports the given API schemas' attributes as Maya custom attributes. This only recognizes API schemas that have been applied to prims on the stage. The attributes will properly round-trip if you re-export back to USD. | | |||
| | `-chaser` | `-chr` | string(multi) | none | Specify the import chasers to execute as part of the import. See "Import Chasers" below. | | |||
| | `-chaserArgs` | `-cha` | string[3] multi| none | Pass argument names and values to import chasers. Each argument to `-chaserArgs` should be a triple of the form: (`<chaser name>`, `<argument name>`, `<argument value>`). See "Import Chasers" below. | | |||
| | `-defaultPrim` | `-dp` | string | none | Set the default prim on export. | | |||
There was a problem hiding this comment.
The doc was in the import section instead of the export section.
pierrebai-adsk
commented
Jun 3, 2024
| @@ -41,8 +41,7 @@ class UsdMayaPrimWriterArgs | |||
| UsdMayaPrimWriterArgs( | |||
| const MDagPath& dagPath, | |||
| const bool exportRefsAsInstanceable, | |||
| const TfToken::Set& excludeExportTypes, | |||
| const std::string& defaultPrim); | |||
There was a problem hiding this comment.
The default prim was not used anywhere so I removed it.
There was a problem hiding this comment.
I also checked and the _defaultPrim is private and isn't being used from anywhere. Good catch!
pierrebai-adsk
commented
Jun 3, 2024
| @@ -562,6 +562,18 @@ bool _MergeJobContexts(bool isExport, const VtDictionary& userArgs, VtDictionary | |||
| return canMergeContexts; | |||
| } | |||
|
|
|||
| bool _GetEncodedArg(const MString& option, std::string& argName, MString& argValue) | |||
| { | |||
There was a problem hiding this comment.
Refactored common code shared between import and export job args.
pierrebai-adsk
requested review from
samuelliu-adsk and
AramAzhari-adsk
and removed request for
samuelliu-adsk
AramAzhari-adsk
approved these changes
Jun 3, 2024
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the material scope name to the default-prim drop-down when meshes are off and materials are on.
Bug fixes and improvements:
Change how no-default-prim is expressed
Add unit tests.