Fix AE extra attribute section. #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change broke which attributes are added to the extra attributes section. That is because the default function to create an attribute UI returns None and was interpreted as no UI being created. This is a unfortunate consequence of the design: the return value is interpreted as sucsess or failure of creating a UI and then, on success, custom callbacks are connected to that UI. But for the default fallback, those callbacks must not be added, so it returns None, which was interpreted as failure. Given that it is the final fallback, that had no consequences, but a code change made registering the attribute as being handled was no longer done properly. Restore the old code, which was adding the attribute to teh list of known, handled attributes. Also, don't add supressed attributes in the extra attribute section.
AramAzhari-adsk
approved these changes
Dec 2, 2024
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change broke which attributes are added to the extra attributes section. That is because the default function to create an attribute UI returns None and was interpreted as no UI being created.
This is a unfortunate consequence of the design: the return value is interpreted as success or failure of creating a UI and then, on success, custom callbacks are connected to that UI. But for the default fallback, those callbacks must not be added, so it returns None, which was interpreted as failure. Given that it is the final fallback, that had no consequences, but a code change made registering the attribute as being handled was no longer done properly.
Restore the old code, which was adding the attribute to the list of known, handled attributes. Also, don't add suppressed attributes in the extra attribute section.