Address remaining feedback in lib/usd and plugin/adsk #408
Conversation
- Fix private headers in translator promoted as public - Fix grouping order
|
@mattyjams see c6eecc5 that addresses all your feedback in PART III. |
There was a problem hiding this comment.
I noted a few more things, but nothing that should block any of the open PRs. I think we should probably stop at this point and merge in everything we have, and we can take another pass through afterwards. It's becoming too difficult to cross reference all of the notes across many open pull requests each with multiple commits.
| @@ -31,7 +31,7 @@ | |||
| #include <mayaUsd/utils/colorSpace.h> | |||
| #include <mayaUsd/utils/util.h> | |||
|
|
|||
| #include <mayaUsd_Translators/meshWriter.h> | |||
| #include "meshWriter.h" | |||
There was a problem hiding this comment.
meshWriter.h to me is the related header for this file, so I'd think it should go at the top in a group of its own.
| #include <mayaUsd_Translators/jointWriter.h> | ||
| #include <mayaUsd_Translators/meshWriter.h> | ||
| #include "jointWriter.h" | ||
| #include "meshWriter.h" |
There was a problem hiding this comment.
meshWriter.h is the related header so it should go at the top.
| @@ -19,7 +19,7 @@ | |||
| #include <pxr/pxr.h> | |||
| #include <pxr/usd/usdGeom/mesh.h> | |||
|
|
|||
| #include <mayaUsd_Translators/meshWriter.h> | |||
| #include "meshWriter.h" | |||
There was a problem hiding this comment.
meshWriter.h is the related header so it should go at the top.
| @@ -44,6 +35,15 @@ | |||
| #include "importTranslator.h" | |||
| #include "ProxyShape.h" | |||
|
|
|||
| #include <mayaUsd/utils/undoHelperCommand.h> | |||
There was a problem hiding this comment.
This include is not part of a conditional and should stay with the mayaUsd group above.
HamedSabri-adsk
deleted the
sabrih/sabrih/address_lib_usd_plugin_adsk_remaning_issues
branch
Hey guys,
This PR fixes conditional orders in lib/usd and plugin/adsk.
Only 6 files :)