Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-104219 - Rename 'Create Stage from Existing Layer' #413

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

seando-adsk
Copy link
Collaborator

MAYA-104219 - Change 'Create Stage from Existing Layer' to 'Create Stage from File'

  • Renamed menu/options/etc according to request from design.
  • Renamed everything else (runtimecommands/procs/file/etc) to be consistent.

…age from File'

* Renamed menu/options/etc according to request from design.
* Renamed everything else (runtimecommands/procs/file/etc) to
  be consistent.
Copy link
Collaborator Author

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've indicated all the changes that were requested by design. All the other changes were made to keep everything consistent with the renamed items.

runTimeCommand -default true
-label "Stage From Existing Layer..."
-annotation "Create a USD Stage from an existing USD layer"
-label "Stage From File..."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from design

runTimeCommand -default true
-annotation "Create a USD Stage from an existing USD layer options"
-annotation "Create a USD Stage from an existing USD file options"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from design

setParent $parent;
string $layout = `scrollLayout -childResizable true`;

frameLayout -label "USD Layer Options" -collapsable false;
frameLayout -label "USD File Options" -collapsable false;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from design

@@ -146,7 +146,7 @@ global proc mayaUsd_createStagesFromExistingLayerOptions()
$parent;

string $applyCloseBtn = getOptionBoxApplyAndCloseBtn();
button -edit -label "Create Stages"
button -edit -label "Create Stage"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from design

@@ -170,7 +170,7 @@ global proc mayaUsd_createStagesFromExistingLayerOptions()
-command ($callback + " " + $parent + " " + 0)
$saveBtn;

setOptionBoxTitle("Create USD Stage Options");
setOptionBoxTitle("Create USD Stage from File Options");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from design

string $result[] = `fileDialog2
-fileMode 1
-caption "Create USD Stage From Existing Layer"
-caption "Create USD Stage from File"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from design

@seando-adsk seando-adsk requested a review from fowlertADSK April 8, 2020 20:43
@kxl-adsk kxl-adsk added proxy Related to base proxy shape workflows Related to in-context workflows labels Apr 8, 2020
Copy link
Contributor

@fowlertADSK fowlertADSK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for taking the time to rename all of the various places the term showed up instead of just changing the UI. Makes things much more clear when you are searching source.

@kxl-adsk kxl-adsk merged commit 1091ce4 into dev Apr 9, 2020
@kxl-adsk kxl-adsk deleted the donnels/MAYA-104219/rename_create_stage branch April 9, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proxy Related to base proxy shape workflows Related to in-context workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants