MAYA-101454 Clear stage cach on file new/open. #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowlertADSK
commented
Apr 16, 2020
| @@ -134,6 +135,8 @@ MStatus initializePlugin(MObject obj) | |||
| } | |||
| } | |||
|
|
|||
| UsdMayaSceneResetNotice::InstallListener(); | |||
There was a problem hiding this comment.
This was already being installed by the Pixar plugin, but MayaUSD should also be using it.
ppt-adsk
approved these changes
Apr 16, 2020
BigRoy
reviewed
Apr 16, 2020
lib/mayaUsd/listeners/notice.cpp
Outdated
| @@ -24,6 +24,11 @@ PXR_NAMESPACE_OPEN_SCOPE | |||
|
|
|||
| namespace { | |||
|
|
|||
| // Siple ref count for how many plugins have initialized the callback. | |||
kxl-adsk
approved these changes
Apr 17, 2020
kxl-adsk
added
adsk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change that reuses existing code that will reset the stage cache on New or Open, fixing some logged issues. It is not a complete fix for how we deal with the cache though, e.g. deleting the proxy shape and re-importing the same USD file will still show you the cached version which is probably unexpected. The listener here is only called on File -> New and Open.
We do plan on looking at how the Animal Logic plugin deals with this kind of thing and will most likely refactor some of that into the core lib to be shared by all plugins, but for right now this is an easy change that should help in a couple obvious workflows.