-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PXR_PATCH_VERSION! #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa... Does anything actually use or depend on this? I hope not! If anything does, it should get plumbed through from FindUSD.cmake, but that currently only exports USD_VERSION
and USD_VERSION_NUM
.
Can we just nuke this whole Version.cmake file instead?
Hey Matt, exactly I was wondering too since nobody uses this. I will nuke it :) |
@mattyjams see 46b4565 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Looks good to me! Thanks @HamedSabri-adsk!
Great, I'm happy to see it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix compilation errors (all platforms are failing):
see https://github.com/Autodesk/maya-usd/blob/dev/plugin/pxr/cmake/macros/Private.cmake#L16
Should be fixed in bb84d2c |
set patch number to 5.