Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PXR_PATCH_VERSION! #440

Merged
merged 3 commits into from
Apr 18, 2020
Merged

Fix PXR_PATCH_VERSION! #440

merged 3 commits into from
Apr 18, 2020

Conversation

HamedSabri-adsk
Copy link
Contributor

set patch number to 5.

@HamedSabri-adsk HamedSabri-adsk added the build Related to building maya-usd repository label Apr 18, 2020
Copy link
Contributor

@mattyjams mattyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa... Does anything actually use or depend on this? I hope not! If anything does, it should get plumbed through from FindUSD.cmake, but that currently only exports USD_VERSION and USD_VERSION_NUM.

Can we just nuke this whole Version.cmake file instead?

@HamedSabri-adsk
Copy link
Contributor Author

Hey Matt, exactly I was wondering too since nobody uses this.

I will nuke it :)

@HamedSabri-adsk
Copy link
Contributor Author

@mattyjams see 46b4565

Copy link
Contributor

@mattyjams mattyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Looks good to me! Thanks @HamedSabri-adsk!

@kxl-adsk
Copy link

Great, I'm happy to see it

Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HamedSabri-adsk
Copy link
Contributor Author

Please fix compilation errors (all platforms are failing):
see https://github.com/Autodesk/maya-usd/blob/dev/plugin/pxr/cmake/macros/Private.cmake#L16

Should be fixed in bb84d2c

@kxl-adsk kxl-adsk merged commit ec3853c into dev Apr 18, 2020
@kxl-adsk kxl-adsk deleted the sabrih/fix_pxr_version branch April 18, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants