plugin/pxr is now adopting mayaUsd_compile_config routine #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2020 14:47
…options are either unused or have been OFF for ever.
mattyjams
approved these changes
Apr 21, 2020
Comment on lines
+32
to
+34
| option(PXR_ENABLE_PYTHON_SUPPORT "Enable Python based components for USD" ON) | ||
| option(PXR_BUILD_TESTS "Build tests" ON) | ||
| option(PXR_BUILD_MONOLITHIC "Build a monolithic library." OFF) |
There was a problem hiding this comment.
These options and their corresponding code should probably all get removed, but we can punt on that for now.
HamedSabri-adsk
merged commit b0c1441
into
sabrih/MAYA-103926/compiler_configuration_mayausd
kxl-adsk
deleted the
sabrih/MAYA-103926/compiler_configuration_plugin_pxr
branch
ppt-adsk
added a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #412, plugin/pxr is now getting the compiler configuration by using mayaUsd_compile_config.
I didn't delete
defaultssub-directory and left it there by itself for now.