Improve rename logics

lib/mayaUsd/ufe/UsdUndoRenameCommand.cpp

@@ -61,18 +61,17 @@ UsdUndoRenameCommand::UsdUndoRenameCommand(const UsdSceneItem::Ptr& srcItem, con
     else
     {
         // account for internal vs external references
+        // internal references (references without a file path specified) from the same file
+        // should be renamable.
         if (prim.HasAuthoredReferences()) {
             auto primSpec = MayaUsdUtils::getPrimSpecAtEditTarget(_stage, prim);
-            for (const SdfReference& ref : primSpec->GetReferenceList().GetAddedOrExplicitItems()) {
-                // GetAssetPath returns the asset path to the root layer of the referenced layer
-                // this will be empty in the case of an internal reference.
-                if (ref.GetAssetPath().empty()) { 
-                    return;
-                }else{
-                   std::string err = TfStringPrintf("Unable to rename referenced object [%s]", 
-                                                    prim.GetName().GetString().c_str());
-                   throw std::runtime_error(err.c_str());
-                }
+
+            if(MayaUsdUtils::isInternalReference(primSpec)) {
+                return;
+            }else {
+                std::string err = TfStringPrintf("Unable to rename referenced object [%s]", 
+                                                  prim.GetName().GetString().c_str());
+                throw std::runtime_error(err.c_str());
             }
         }
 

lib/usd/utils/util.cpp

@@ -101,4 +101,20 @@ getPrimSpecAtEditTarget(UsdStageWeakPtr stage, const UsdPrim& prim)
     return stage->GetEditTarget().GetPrimSpecForScenePath(prim.GetPath());
 }
 
+bool
+isInternalReference(const SdfPrimSpecHandle& primSpec)
+{
+    bool isInternalRef{false};
+
+    for (const SdfReference& ref : primSpec->GetReferenceList().GetAddedOrExplicitItems()) {
+        // GetAssetPath returns the asset path to the root layer of the referenced layer
+        // this will be empty in the case of an internal reference.
+        if (ref.GetAssetPath().empty()) {
+            isInternalRef = true;
+        }
+    }
+
+    return isInternalRef;
+}
+
 } // MayaUsdUtils

lib/usd/utils/util.h

@@ -45,6 +45,10 @@ namespace MayaUsdUtils {
     MAYA_USD_UTILS_PUBLIC
     SdfPrimSpecHandle getPrimSpecAtEditTarget(UsdStageWeakPtr, const UsdPrim&);
 
+    //! Returns true if the prim spec has an internal reference.
+    MAYA_USD_UTILS_PUBLIC
+    bool isInternalReference(const SdfPrimSpecHandle&);
+
 } // namespace MayaUsdUtils
 
 #endif // MAYAUSDUTILS_UTIL_H