Add override flag for setting WORKING_DIRECTORY #508
Conversation
| # set the working_dir | ||
| if(PREFIX_WORKING_DIRECTORY) | ||
| set(working_dir ${PREFIX_WORKING_DIRECTORY}) | ||
| else() | ||
| set(working_dir ${CMAKE_CURRENT_SOURCE_DIR}) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Now that I look at this again, I realize this can simplified. I will make a commit to address this.
if(NOT PREFIX_WORKING_DIRECTORY)
set(working_dir ${CMAKE_CURRENT_SOURCE_DIR})
endif()
There was a problem hiding this comment.
Hmm... I don't quite understand your fix - I think the set(working_dir ${PREFIX_WORKING_DIRECTORY}) is needed, isn't it? Or are there other changes, too? I guess I'll wait for the actual commit.
There was a problem hiding this comment.
@elrond79 Sorry, Yes ignore my comment here. I am not sure what I was thinking when I wrote this comment. It has been a long day......
Everything as is should be fine. Thanks.
| # set the working_dir | ||
| if(PREFIX_WORKING_DIRECTORY) | ||
| set(working_dir ${PREFIX_WORKING_DIRECTORY}) | ||
| else() | ||
| set(working_dir ${CMAKE_CURRENT_SOURCE_DIR}) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Hmm... I don't quite understand your fix - I think the set(working_dir ${PREFIX_WORKING_DIRECTORY}) is needed, isn't it? Or are there other changes, too? I guess I'll wait for the actual commit.
Added a new flag to allow overriding
WORKING_DIRECTORY. If this flag is not set, ${CMAKE_CURRENT_SOURCE_DIR} is used hence the default behavior.UFE tests are supposed to run from build directory. We already copy all the python tests and resource to build directory and therefore WORKING_DIRECTORY needs to be set to ${CMAKE_CURRENT_BINARY_DIR}