Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-104776 send a notice that a newly created proxy shape is dirty #536

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

fowlertADSK
Copy link
Contributor

The workflow that shows the problem here:

  1. Create a new proxy shape.
  2. Right click on the proxy shape and you will see the UFE/USD menu items, e.g. "Add new prim".
  3. Create another new proxy shape. Not from file, an empty one.
  4. Right click the new proxy shape and you will not see the UFE/USD menu items.

This happens because we maintain a map of proxy shapes <-> USD stages that gets updated only when dirty. The map currently only gets dirtied when the file path attribute on the proxy shape changes, which worked fine until we added a command to create a new empty stage + proxy shape. In this case we were not notifying anyone that there was a new/dirty item so the map was not dirtied and we do not update the popup menu.

@fowlertADSK fowlertADSK requested a review from seando-adsk May 28, 2020 20:50
@fowlertADSK fowlertADSK added the bug Something isn't working label May 29, 2020
@robthebloke
Copy link
Contributor

I think we saw the same issue and kinda hacked around it in a slightly dirtier way. The change looks good, but I'm going to hold off approving until later this evening so I can run this through our integration tests

@fowlertADSK fowlertADSK requested a review from robthebloke June 3, 2020 10:49
@kxl-adsk kxl-adsk merged commit 2d6e12e into dev Jun 4, 2020
@kxl-adsk kxl-adsk deleted the fowlert/MAYA-104776/init_proxy_as_dirty branch June 4, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants