-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAYA-101853 Changes necessary for UDIM texture support. #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…change in USD, commit 4e426565, which isn't merged into the standard version of USD that we build against, so it won't actually work yet. But the source itself can compile fine without that change and the behavior isn't any worse, so I will commit the changes anyway.
… the USD functions I am using.
JGamache-autodesk
approved these changes
May 29, 2020
Maybe ask QA to upload a RTS test so we know when it is fixed. |
Good idea, I will follow up in JIRA with George. |
…e don't handle. Correctly set isColorSpaceSRGB.
huidong-chen
approved these changes
Jun 1, 2020
ecg-mayausd-branch-preflight-master-public run 119 |
kxl-adsk
suggested changes
Jun 1, 2020
MayaUsd - Build External GitHub Branch 121 |
kxl-adsk
approved these changes
Jun 1, 2020
… have any values in it.
MayaUsd - Build External GitHub Branch run 126 |
huidong-chen
reviewed
Jun 2, 2020
MayaUsd - Build External GitHub Branch run 128 |
huidong-chen
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change depends on a change in USD, commit 4e426565, which isn't merged into the standard version of USD that we build against, so it won't actually work yet. But the source itself can compile fine without that change and the behavior isn't any worse, so I will commit the changes anyway.
This commit + 4e426565 fixes issue #89