MAYA-105120 Hide MRenderItems created for instancers with zero instances. #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamkrick
commented
Jun 8, 2020
|
Please add the same fix to basisCurves. |
huidong-chen
suggested changes
Jun 8, 2020
We need a way to share code between basisCurves & mesh. There is a lot of duplicate stuff between the two of them. |
williamkrick
commented
Jun 8, 2020
Extractly. I think this can be done when we start to implement the third Rprim class. |
huidong-chen
approved these changes
Jun 8, 2020
robthebloke
approved these changes
Jun 9, 2020
kxl-adsk
approved these changes
Jun 9, 2020
kxl-adsk
deleted the
krickw/MAYA-105120/hide_instanced_meshes_with_zero_instances
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of setting up an instanced MRenderItem in Vp2RenderDelegate we'd set the prototype geometry on the item. At this point the MRenderItem looks to Maya like any other drawable item (with an identity transform matrix). Then we set the instance transforms and the MRenderItem changes to an instanced item and we handle the drawing differently.
The problem is when there is a USD instances with no instances we never do that second step, so the item stays a regular Maya item and we draw it normally, which is not what we want to happen.
The solution is detect that there is an instancer with zero instance transforms and hide the MRenderItem in those cases.
#404 #522