Fix the regression for selecting single instance objects. #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huidong-chen
commented
Jul 3, 2020
|
|
||
| const Ufe::PathSegment pathSegment(usdPath.GetText(), USD_UFE_RUNTIME_ID, USD_UFE_SEPARATOR); | ||
| const Ufe::SceneItem::Ptr& si = handler->createItem(_proxyShapeData->ProxyShape()->ufePath() + pathSegment); | ||
| if (!si) { | ||
| TF_WARN("UFE runtime is not updated for the USD stage. Please save scene and reopen."); | ||
| TF_WARN("Failed to create UFE scene item for Rprim '%s'", rprimId.GetText()); |
There was a problem hiding this comment.
The previous warning message is no longer valid.
huidong-chen
commented
Jul 3, 2020
|
|
||
| const SdfPath usdPath(_sceneDelegate->ConvertIndexPathToCachePath(rprimId)); |
There was a problem hiding this comment.
ConvertIndexPathToCachePath() is only required when calling with GetPathForInstanceIndex().
huidong-chen
commented
Jul 3, 2020
| const int drawInstID = intersection.instanceID(); | ||
| const int usdInstID = drawInstID - 1; | ||
|
|
||
| #if defined(USD_IMAGING_API_VERSION) && USD_IMAGING_API_VERSION >= 13 |
There was a problem hiding this comment.
I fixed the single instance selection issue for both conditional compilation branches.
huidong-chen
requested review from
kxl-adsk and
mattyjams
and removed request for
kxl-adsk
huidong-chen
commented
Jul 3, 2020
| #if defined(USD_IMAGING_API_VERSION) && USD_IMAGING_API_VERSION >= 13 | ||
| rprimId = _sceneDelegate->GetScenePrimPath(rprimId, usdInstID); | ||
| const int usdInstID = drawInstID > 0 ? drawInstID - 1 : 0; | ||
| SdfPath usdPath = _sceneDelegate->GetScenePrimPath(rprimId, usdInstID); |
There was a problem hiding this comment.
@mattyjams I think this new API also handles nested instancing, selection for nested instancing case can work as expected (before this API we could only select the highest instancing group but not an exact instance from the viewport). Very nice!
kxl-adsk
approved these changes
Jul 4, 2020
kxl-adsk
deleted the
chenh/MAYA-102530/fix-selection-regression-for-single-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression #153 was caused by not using instanced draw for single-instance objects and reproducible on Maya 2020 and before.
Recent Maya preview releases already support consolidation for instanced render items so the performance workaround has been removed, therefore the regression won't be reproduced for those preview releases.