Fix anonymous layer default name #660
Conversation
HamedSabri-adsk
added
ufe-usd
lib/mayaUsd/nodes/proxyShapeBase.cpp
Outdated
| @@ -584,7 +585,7 @@ MayaUsdProxyShapeBase::computeInStageDataCached(MDataBlock& dataBlock) | |||
| } | |||
| else { | |||
| // Create a new stage in memory with an anonymous root layer. | |||
| usdStage = UsdStage::CreateInMemory("", loadSet); | |||
| usdStage = UsdStage::CreateInMemory(kanonymousLayerName, loadSet); | |||
There was a problem hiding this comment.
@seando-adsk Setting identifier passed to CreateInMemory routine automatically sets the anonymous name.
lib/mayaUsd/nodes/proxyShapeBase.cpp
Outdated
| @@ -98,6 +98,7 @@ TF_DEFINE_PUBLIC_TOKENS(MayaUsdProxyShapeBaseTokens, | |||
| MayaUsdProxyShapeBase::ClosestPointDelegate | |||
| MayaUsdProxyShapeBase::_sharedClosestPointDelegate = nullptr; | |||
|
|
|||
| const auto kanonymousLayerName{"anonymousLayer1"}; | |||
There was a problem hiding this comment.
createInMemory takes a std::string, so instead of auto why not make this a std::string?
According to our coding standards constants "should be named with a leading “k” followed by UpperCamelCase". So this should be "kA..."
There was a problem hiding this comment.
auto already deduces the type to std::string.
There was a problem hiding this comment.
@seando-adsk please see 5dd8221
| @@ -98,6 +98,7 @@ TF_DEFINE_PUBLIC_TOKENS(MayaUsdProxyShapeBaseTokens, | |||
| MayaUsdProxyShapeBase::ClosestPointDelegate | |||
| MayaUsdProxyShapeBase::_sharedClosestPointDelegate = nullptr; | |||
|
|
|||
| const std::string kAnonymousLayerName{"anonymousLayer1"}; | |||
There was a problem hiding this comment.
Not a blocker for the change...but non exported definitions we prefer to put in the unnamed namespace - https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities. Consider adapting to this rule in a new PR.
No description provided.