MAYA-105743 Use the correct type when creating a new group #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowlertADSK
commented
Jul 21, 2020
| _primToken = (type.empty() || type == "Def") ? TfToken() : TfToken(name); | ||
| _primToken = (type.empty() || type == "Def") ? TfToken() : TfToken(type); |
There was a problem hiding this comment.
No idea how this got left as "name" seeing as this problem was the first thing I discovered when implementing the new command.
fowlertADSK
commented
Jul 21, 2020
Comment on lines
+95
to
+99
| # Make sure the new group item has the correct Usd type | ||
| newGroupItem = ufe.Hierarchy.createItem(newGroupPath) | ||
| newGroupPrim = usdUtils.getPrimFromSceneItem(newGroupItem) | ||
| newGroupType = newGroupPrim.GetTypeName() | ||
| self.assertEqual(newGroupType, 'Xform') |
There was a problem hiding this comment.
Make sure the new group is an Xform. Our new group command always uses the Xform type, the context op's code in the Outliner is the one that can pass a number of different types.
ppt-adsk
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a typo in my group command change. Problem was that I used the variable for the name of the new object when defining the prim type. Fixed that and added to the group test to make sure it's correct.