MAYA-103230 Cleaned-up export material UI #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tafowler
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
LGTM!
The only thing I would comment on, but I'll assume you've tested and everything is fine, would be to watch out for building up strings in MEL from other strings that have spaces in them. It can get annoying when you're not sure if you need to include " at the start/end of strings to make sure it all runs correctly.
e.g. I think you're building a string in mayaUsdTranslatorExport_AppendFromMaterialPopup from a string array, where there are spaces in the string... If you've tested it and we don't need any extra quoting then we're all good.
JGamache-autodesk
added
the
ready-for-merge
kxl-adsk
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tooltips, updated some labels, reordered the entries and made useRegistry the new default.