move pxrUsdStageNode and pxrUsdPointBasedDeformerNode registration to mayaUsd core #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mayaUsd core These nodes are created when the "useAsAnimationCache" import arg is used. The import arg is built into the base import command, so the nodes must be registered and de-registered in the core, otherwise imports that use the arg will fail.
This clears the way for a MAYAUSD_NODES_TEST target in test/lib/mayaUsd/nodes.
…ib/mayaUsd/nodes/... This change moves the unit test for the pxrUsdPointBasedDeformerNode in lib/mayaUsd/nodes from usdMaya in the Pixar plugin area to test/... A new directory was created for these node-specific tests.
…... as testUsdImportExportTypelessDefs
kxl-adsk
approved these changes
Oct 13, 2020
kxl-adsk
added
the
ready-for-merge
mattyjams
deleted the
pr/move_stage_and_deformer_nodes_to_core_and_move_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually fixes a breakage when using just the
mayaUsdPlugin. TheuseAsAnimationCachearg for import is part of the base import command, but thepxrUsdStageNodeandpxrUsdPointBasedDeformerNodenodes were only being registered with thepxrUsdplugin. This means that attempting to use theuseAsAnimationCachewithcmds.mayaUSDImport()would fail ifpxrUsdwas not loaded. That is fixed be 14acc4c.The other commits migrate the test for the point-based deformer as well as for typeless def translation from
plugin/pxr/...totest/....