fixes for testProxyShapeSelectionPerformance when run with the VP2 render delegate #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… USD assets We'll be setting the USD selection kind optionVar to "assembly" when we run the testProxyShapeSelectionPerformance, so this kind needs to be set on the root prims for them to be selected.
…ectionPerformance When using the Pixar batch renderer, we select entire USD "assets" by clicking on them in the viewport. We mimic this behavior with the Viewport 2.0 render delegate by setting kind=assembly on the root-level prims and using that same kind to set the "UsdSelectionKind" optionVar.
When the Viewport 2.0 render delegate is being used, we will have selected USD prims rather than proxy shape nodes or their transform nodes, so in that case we query UFE for the selection and manipulate the paths of the selected scene items to yield the Maya-side selection.
…ShapeSelectionPerformance This ensures that the rendered image includes selection highlighting when using the Viewport 2.0 render delegate.
kxl-adsk
approved these changes
Oct 14, 2020
kxl-adsk
added
the
ready-for-merge
mattyjams
deleted the
pr/fixes_for_testProxyShapeSelectionPerformance_with_VP2_render_delegate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes get the
testProxyShapeSelectionPerformancetest passing when run with the Viewport 2.0 render delegate. The test can be run in that configuration by settingVP2_RENDER_DELEGATE_PROXY=1here:maya-usd/test/lib/mayaUsd/render/pxrUsdMayaGL/CMakeLists.txt
Line 45 in 50eb2c6
There are three main issues addressed here:
UsdSelectionKindoptionVar set toassemblyto pick assets at a coarser granularity. Since theCubeGrid..._10.usdfiles are binary, the changes to them aren't directly visible here, but the only update was to setkind=assemblyon the root prim in each of those files.kind=assembly, we still end up selecting a UFE item representing a root USD prim with the VP2 render delegate. To make the behavior consistent with the non-VP2 render delegate case, we just cleave off the root prim and proxy shape segments of the item's path, leaving the proxy's transform node name at the end which is what gets selected in the Pixar batch renderer configuration.UIobject filter in thehardwareRenderingGlobals.