MAYA-106892 - Export and import color space information on file nodes #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On export, if the color space of a file node was set (differs from the global rule) then we export it as a colorSpace metadata on the file UsdShadeInput. On import, if there is a colorSpace on the USD file input, we set it in the Maya file node.
mattyjams
approved these changes
Oct 22, 2020
Comment on lines
226
to
230
| MString colorRuleCmd; | ||
| colorRuleCmd.format( | ||
| "colorManagementFileRules -evaluate \"^1s\";", fileTextureNamePlug.asString()); | ||
| const MString colorSpaceByRule = MGlobal::executeCommandStringResult(colorRuleCmd); | ||
|
|
There was a problem hiding this comment.
Maybe move this closer to where we get the colorSpace plug, or even inside that if (status == MS::kSuccess) { block?
JGamache-autodesk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On export, if the color space of a file node was set (differs from the global rule) then we export it as a colorSpace metadata on the file UsdShadeInput.
On import, if there is a colorSpace on the USD file input, we set it in the Maya file node.